<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/7520">View Change</a></p><p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(4 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/7520/2/main/loader.c">File main/loader.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7520/2/main/loader.c@154">Patch Set #2, Line 154:</a> <code style="font-family:monospace,monospace">     * Returns comparison values for a min-heap</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">min-heap?  We're sorting a vector.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7520/2/main/loader.c@586">Patch Set #2, Line 586:</a> <code style="font-family:monospace,monospace">static struct ast_module *load_dynamic_module(const char *resource_in, unsigned int global_symbols_only, unsigned int suppress_logging, struct module_vector *resource_heap)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">resource_heap is an unused parameter.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7520/2/main/loader.c@1194">Patch Set #2, Line 1194:</a> <code style="font-family:monospace,monospace">          AST_VECTOR_ADD_SORTED(resource_heap, mod, module_vector_cmp);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This can fail if the vector has to resize.</p><p style="white-space: pre-wrap; word-wrap: break-word;">The previous ast_heap_push() could have failed too for the same reason.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7520/2/main/loader.c@1265">Patch Set #2, Line 1265:</a> <code style="font-family:monospace,monospace">    AST_VECTOR_INIT(&resource_heap, 10);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This can fail.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Would we not want to assume an initial size of 500 so the vector is unlikely to realloc?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/7520">change 7520</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/7520"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ia23421197f09789940510b03ebbbf3bf24d51bea </div>
<div style="display:none"> Gerrit-Change-Number: 7520 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 15 Dec 2017 01:41:41 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>