<p>Corey Farrell <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/7268">View Change</a></p><p>Patch set 3:</p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/7268/3/main/asterisk.c">File main/asterisk.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7268/3/main/asterisk.c@3175">Patch Set #3, Line 3175:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">             while (matches[nummatches + 1]) {<br>                     nummatches++;<br>         }<br><br>           if (ast_opt_remote && nummatches > 1) {<br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">I might be reading this wrong, but why the "nummatches + 1"? Won't that mak</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Index 0 is the "best match" so we want nummatches one less than the number of non-NULL elements in the array.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/7268">change 7268</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/7268"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ie2211b519a3d4bec45bf46e0095bdd01d384cb69 </div>
<div style="display:none"> Gerrit-Change-Number: 7268 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 21 Nov 2017 19:46:42 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>