<p>Kevin Harwell <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/7258">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/7258/1/tests/test_substitution.c">File tests/test_substitution.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7258/1/tests/test_substitution.c@309">Patch Set #1, Line 309:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">      funcs = ast_cli_completion_vector("core show function", "");<br><br>    /* Skip "best match" element 0 */<br>   for (i = 1; i < AST_VECTOR_SIZE(funcs); i++) {<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Need a NULL check here. If "funcs" is NULL then the vector size check will blow up.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/7258">change 7258</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/7258"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I8cd6b93905363cf7a33a2d2b0e2a8f8446d9f248 </div>
<div style="display:none"> Gerrit-Change-Number: 7258 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 20 Nov 2017 20:58:19 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>