<p>Corey Farrell <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/7164">View Change</a></p><p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(3 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/7164/2/res/res_sorcery_astdb.c">File res/res_sorcery_astdb.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7164/2/res/res_sorcery_astdb.c@341">Patch Set #2, Line 341:</a> <code style="font-family:monospace,monospace">        snprintf(tree, sizeof(tree), "%s%%", prefix);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Since we are passing prefix_len I assume it's possible that prefix[prefix_len] != '\0'.  I think you need to use:<br>snprintf(tree, sizeof(tree), "%.*s%%", prefix_len, prefix)</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/7164/2/res/res_sorcery_realtime.c">File res/res_sorcery_realtime.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7164/2/res/res_sorcery_realtime.c@272">Patch Set #2, Line 272:</a> <code style="font-family:monospace,monospace">     if (!ast_strlen_zero(prefix)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">if (prefix_len && !ast_strlen_zero(prefix))</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7164/2/res/res_sorcery_realtime.c@274">Patch Set #2, Line 274:</a> <code style="font-family:monospace,monospace">                snprintf(value, sizeof(value), "%s%%", prefix);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same as astdb snprintf.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/7164">change 7164</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/7164"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I56f4e20ba1154bd52281f995c27a429a854f6a79 </div>
<div style="display:none"> Gerrit-Change-Number: 7164 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 13 Nov 2017 19:07:43 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>