<p>Joshua Colp <strong>merged</strong> this change.</p><p><a href="https://gerrit.asterisk.org/7105">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Richard Mudgett: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, approved; Approved for Submit

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bridge_softmix: Note why ast_stream_topology_set_stream cannot fail.<br><br>This appeared in my audit of ast_stream_topology_set_stream callers<br>not checking for errors but in this situation the call cannot fail.<br>Add comment so this can be ignored in the future.<br><br>Change-Id: I91d25704859efbe50b8b82cfe1cd3c40ba177c9f<br>---<br>M bridges/bridge_softmix.c<br>1 file changed, 2 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/bridges/bridge_softmix.c b/bridges/bridge_softmix.c<br>index f490967..8de88f2 100644<br>--- a/bridges/bridge_softmix.c<br>+++ b/bridges/bridge_softmix.c<br>@@ -541,6 +541,8 @@<br>                     dest_index++;<br> <br>                      if (ast_stream_get_state(stream) == AST_STREAM_STATE_REMOVED) {<br>+                              /* This cannot fail because dest_index - 1 is less than the<br>+                           * current count in dest. */<br>                          ast_stream_topology_set_stream(dest, dest_index - 1, clone);<br>                          added = 1;<br>                            break;<br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/7105">change 7105</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/7105"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I91d25704859efbe50b8b82cfe1cd3c40ba177c9f </div>
<div style="display:none"> Gerrit-Change-Number: 7105 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>