<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/7083">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(3 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/7083/1/res/res_pjsip_pubsub.c">File res/res_pjsip_pubsub.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7083/1/res/res_pjsip_pubsub.c@1224">Patch Set #1, Line 1224:</a> <code style="font-family:monospace,monospace">                       ao2_cleanup(tree);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Add a note like below for why we are cleaning up tree here.  It isn't obvious.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Have to release tree here too because a ref was added to child that destroy_subscription() doesn't release.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7083/1/res/res_pjsip_pubsub.c@2232">Patch Set #1, Line 2232:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> if (AST_VECTOR_SIZE(&body_parts) == 0) {<br>          return NULL;<br>  }<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Need to call<br>free_body_parts(&body_parts);<br>before returning or we leak the body_parts vector.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7083/1/res/res_pjsip_pubsub.c@2239">Patch Set #1, Line 2239:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">       if (!rlmi_part) {<br>             return NULL;<br>  }<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Need to call<br>free_body_parts(&body_parts);<br>before returning or we leak the body_parts vector.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/7083">change 7083</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/7083"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I68ece0073ea79667ca41eb10405f516f1d30d482 </div>
<div style="display:none"> Gerrit-Change-Number: 7083 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 07 Nov 2017 20:51:06 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>