<p>Corey Farrell <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/7046">View Change</a></p><p>Patch set 1:</p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/7046/1/main/stream.c">File main/stream.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7046/1/main/stream.c@402">Patch Set #1, Line 402:</a> <code style="font-family:monospace,monospace">                  ast_stream_free(stream);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">This is counter to the other error case in here. It doesn't free the stream</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Ah yes looks like some of the ast_stream_topology_set_stream callers do free the stream on failure.  I'll just let AST_VECTOR_APPEND return the error here and I'll audit callers of ast_stream_topology_set_stream to ensure they don't leak on failure (some do).</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/7046">change 7046</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/7046"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 15 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I6c0d12755743eadba1357f6153526cc055592856 </div>
<div style="display:none"> Gerrit-Change-Number: 7046 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 07 Nov 2017 16:13:48 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>