<p>Joshua Colp <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/6997">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(2 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/6997/1/res/res_pjsip/location.c">File res/res_pjsip/location.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6997/1/res/res_pjsip/location.c@1222">Patch Set #1, Line 1222:</a> <code style="font-family:monospace,monospace">     if(contact->uri == NULL || ast_strlen_zero(contact->uri)){</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">The ast_strlen_zero function already handles if the passed in string is NULL so the initial check is not needed.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6997/1/res/res_pjsip/location.c@1223">Patch Set #1, Line 1223:</a> <code style="font-family:monospace,monospace">          ast_log(LOG_ERROR, "Contact uri is empty\n");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This error message isn't helpful for users - it doesn't explain what AOR has an empty contact. It would be better as:</p><p style="white-space: pre-wrap; word-wrap: break-word;">ast_log(LOG_ERROR, "A contact on AOR '%s' is empty\n", ast_sorcery_object_get_id(object));</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/6997">change 6997</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/6997"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ia0309bdc6b697c73c9c736e1caec910b77ca69f5 </div>
<div style="display:none"> Gerrit-Change-Number: 6997 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Aaron An <anjb@ti-net.com.cn> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 06 Nov 2017 10:30:05 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>