<p>Corey Farrell <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/7022">View Change</a></p><p>Patch set 1:</p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/7022/1/main/stasis_bridges.c">File main/stasis_bridges.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7022/1/main/stasis_bridges.c@883">Patch Set #1, Line 883:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">     if (!out) {<br>           ast_json_unref(json_target);<br>          ast_json_unref(json_transferee);<br>              return NULL;<br>  }<br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Looking at the json pack code it does not appear to clean up any internal r</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I don't think we should work around this jansson bug by potentially calling json_decref extra times.</p><p style="white-space: pre-wrap; word-wrap: break-word;">I've written a patch that I believe will make json pack continue scanning the format string and going through the arguments to decref as needed.  It builds and the current jansson 'make check' passes.  Hopefully tomorrow I'll be able to test that it manages to steal all references in different error conditions.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Feel free to try it out if you want, https://github.com/coreyfarrell/jansson branch always-steal</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/7022">change 7022</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/7022"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ib1181a36b317c86bff1ef2e44a17a0b1c73cfdc8 </div>
<div style="display:none"> Gerrit-Change-Number: 7022 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 07 Nov 2017 04:44:06 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>