<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/6710">View Change</a></p><p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(5 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/6710/2/main/astobj2_container.c">File main/astobj2_container.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6710/2/main/astobj2_container.c@452">Patch Set #2, Line 452:</a> <code style="font-family:monospace,monospace">           orig_lock = __adjust_lock(c, AO2_LOCK_REQ_WRLOCK, 1);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Only need to request read lock level for starters.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6710/2/main/astobj2_container.c@455">Patch Set #2, Line 455:</a> <code style="font-family:monospace,monospace">             ao2_wrlock(c);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Only need to do ao2_rdlock() for starters.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6710/2/main/astobj2_container.c@458">Patch Set #2, Line 458:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">       proxy = ao2_find(c, arg, flags | OBJ_NOLOCK);<br> if (proxy) {<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">go back to the while loop here</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6710/2/main/astobj2_container.c@462">Patch Set #2, Line 462:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">         if (!obj) {<br>                   ao2_unlink_flags(c, proxy, OBJ_NOLOCK);<br>               }<br></pre></blockquote></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">if (obj) {<br>  ao2_ref(proxy, -1);<br>  break;<br>}</pre><p style="white-space: pre-wrap; word-wrap: break-word;">/* Upgrade to a write lock */<br>__adjust_lock(c, AO2_LOCK_REQ_WRLOCK);<br>ao2_unlink_flags(c, proxy, OBJ_NOLOCK);</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6710/2/main/astobj2_container.c@469">Patch Set #2, Line 469:</a> <code style="font-family:monospace,monospace">         __adjust_lock(c, orig_lock, 0);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">/* We'll keep any upgraded lock */<br>__adjust_lock(c, orig_lock, 1);</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/6710">change 6710</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/6710"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I9da822049747275f5961b5c0a7f14e87157d65d8 </div>
<div style="display:none"> Gerrit-Change-Number: 6710 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 10 Oct 2017 23:10:29 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>