<p>Kevin Harwell <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/6675">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(5 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/6675/1/res/ari/resource_bridges.c">File res/ari/resource_bridges.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6675/1/res/ari/resource_bridges.c@202">Patch Set #1, Line 202:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">The extra whitespace can be deleted.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6675/1/res/ari/resource_bridges.c@224">Patch Set #1, Line 224:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> /* Apply bridge features to each of the channel controls */<br> for (i = 0; i < list->count; ++i) {<br> if(!stasis_app_control_bridge_features_init(list->controls[i])) {<br> stasis_app_control_absorb_dtmf_in_bridge(list->controls[i], args->absorb_dtmf);<br> stasis_app_control_mute_in_bridge(list->controls[i], args->mute);<br> }<br> }<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Probably not a huge deal, but can this code be moved up into previous "for loop" instead of iterating over the list a second time?</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/6675/1/res/stasis/control.c">File res/stasis/control.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6675/1/res/stasis/control.c@107">Patch Set #1, Line 107:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">The destructor needs to call to ast_bridge_features_destroy.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6675/1/res/stasis/control.c@1178">Patch Set #1, Line 1178:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> /* Pull bridge features from the control */<br> features = control->bridge_features;<br> control->bridge_features = NULL;<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Probably better to move this below when the control is locked.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6675/1/res/stasis/control.c@1201">Patch Set #1, Line 1201:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> if (res != 0) {<br> ast_log(LOG_ERROR, "Error setting after-bridge callback\n");<br> return -1;<br> }<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">This off nominal path leaks features. Either you'll need a call to ast_bridge_features_destroy here or move the setting of features to after this.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/6675">change 6675</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/6675"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Id4002adfb65c9a8027ee9e1a5f477e0f01cf9d61 </div>
<div style="display:none"> Gerrit-Change-Number: 6675 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Seán C. McCord <ulexus@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 09 Oct 2017 21:59:26 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>