<p>Joshua Colp <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/6630">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(3 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/6630/1/CHANGES">File CHANGES:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6630/1/CHANGES@37">Patch Set #1, Line 37:</a> <code style="font-family:monospace,monospace"> * The "remove_existing" option now removes the soonest to expire contacts a</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This sentence doesn't parse.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/6630/1/configs/samples/pjsip.conf.sample">File configs/samples/pjsip.conf.sample:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6630/1/configs/samples/pjsip.conf.sample@897">Patch Set #1, Line 897:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">;remove_existing=no     ; Determines whether new contacts remove the number of<br>                        ; existing ones over max_contacts which expire the soonest.<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I think this needs to be reworded or extended to be clearer. It's... not easy to read and comprehend.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/6630/1/res/res_pjsip.c">File res/res_pjsip.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6630/1/res/res_pjsip.c@1412">Patch Set #1, Line 1412:</a> <code style="font-family:monospace,monospace">                                         registers random contact addresses to help with NAT and reusing</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">That's not really what it does. It rewrites the contact to the source IP address and port, it's not random.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/6630">change 6630</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/6630"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I64c107a10b70db1697d17136051ae6bf22b5314b </div>
<div style="display:none"> Gerrit-Change-Number: 6630 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 04 Oct 2017 13:20:23 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>