<p>Joshua Colp <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/6572">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p style="white-space: pre-wrap; word-wrap: break-word;">I don't think this is the right way to fix this. Take the video case. With that you really only do want the requested format, because you can't transcode. I see two possible ways forward on this:</p><p style="white-space: pre-wrap; word-wrap: break-word;">1. For audio streams we update it to include all configured audio formats, not just what was requested.</p><p style="white-space: pre-wrap; word-wrap: break-word;">2. We make it so that the format capabilities represent the requested + what we can transcode for all stream types. In cases where we can't transcode it'll stay with what was requested since we know the requester can do it.</p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/6572/1/res/res_pjsip_session.c">File res/res_pjsip_session.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6572/1/res/res_pjsip_session.c@2408">Patch Set #1, Line 2408:</a> <code style="font-family:monospace,monospace">                               endpoint->media.codecs, AST_MEDIA_TYPE_UNKNOWN);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">A stream can only carry one type of media. You can't have formats of different types in it.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/6572">change 6572</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/6572"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 15.0 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Iffabc373bd94cd1dc700925dcfe406e12918c696 </div>
<div style="display:none"> Gerrit-Change-Number: 6572 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 25 Sep 2017 11:25:45 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>