<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/6366">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/6366/1/res/stasis/control.c">File res/stasis/control.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6366/1/res/stasis/control.c@1062">Patch Set #1, Line 1062:</a> <code style="font-family:monospace,monospace">              control->bridge = bridge;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Setting the bridge here is bad when the control gets unlocked for the ast_bridge_impart().  If the callback happens, it "clears" the pointer and then we later set it here.</p><p style="white-space: pre-wrap; word-wrap: break-word;">You may be able to get away with setting the control->bridge pointer before the impart and clear it like control->pbx if it fails.</p><p style="white-space: pre-wrap; word-wrap: break-word;">I don't know the repercussions of setting the pointer early though.  Some other thread may try to depart the channel from the bridge before it has actually gotten into the bridge.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/6366">change 6366</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/6366"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ifd239aa93955b3eb475521f61e284fcb0da2c3b3 </div>
<div style="display:none"> Gerrit-Change-Number: 6366 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 01 Sep 2017 20:08:16 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>