<p>Thierry Magnien has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.asterisk.org/6209">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Workaround for wrong identity in dialog package XML in notify.<br><br>Issue ASTERISK-24488 is due to SIP channel not being in ringing<br>state at the time the NOTIFY is sent, so find_ringing_channel<br>does not return anything.<br><br>This patch allows for multiple device updates until channel<br> is in ringing state and bound to monitored extension.<br><br>Change-Id: Ib31ef1b6dcb9e844b2c1612e634c2a5b88906724<br>---<br>M channels/chan_sip.c<br>M main/pbx.c<br>2 files changed, 7 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/09/6209/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/channels/chan_sip.c b/channels/chan_sip.c<br>index b19c669..ff40d4a 100644<br>--- a/channels/chan_sip.c<br>+++ b/channels/chan_sip.c<br>@@ -15271,6 +15271,9 @@<br> <br>                                    ast_channel_unlock(callee);<br>                                   callee = ast_channel_unref(callee);<br>+                          } else {<br>+                                     /* Don't send wrong remote information */<br>+                                        break;<br>                                }<br> <br>                          /* We create a fake call-id which the phone will send back in an INVITE<br>diff --git a/main/pbx.c b/main/pbx.c<br>index cfc5f7f..baedf0c 100644<br>--- a/main/pbx.c<br>+++ b/main/pbx.c<br>@@ -3564,8 +3564,10 @@<br> <br>   dev_state = stasis_message_data(msg);<br>         if (dev_state->eid) {<br>-             /* ignore non-aggregate states */<br>-            return;<br>+              /* ignore non-aggregate states except for ringing states */<br>+          if (!(dev_state->state == AST_DEVICE_RINGING || dev_state->state == AST_DEVICE_RINGINUSE)) {<br>+                   return;<br>+              }<br>     }<br> <br>  if (ao2_container_count(hintdevices) == 0) {<br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/6209">change 6209</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/6209"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ib31ef1b6dcb9e844b2c1612e634c2a5b88906724 </div>
<div style="display:none"> Gerrit-Change-Number: 6209 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Thierry Magnien <thierry.magnien@gmail.com> </div>