<p>George Joseph <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/6158">View Change</a></p><p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(4 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/6158/3/res/res_xmpp.c">File res/res_xmpp.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6158/3/res/res_xmpp.c@778">Patch Set #3, Line 778:</a> <code style="font-family:monospace,monospace">==</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Shouldn't this be '&&'?</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6158/3/res/res_xmpp.c@779">Patch Set #3, Line 779:</a> <code style="font-family:monospace,monospace">either</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">s/either/or/</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6158/3/res/res_xmpp.c@3904">Patch Set #3, Line 3904:</a> <code style="font-family:monospace,monospace">{</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should be on the following line</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6158/3/res/res_xmpp.c@3905">Patch Set #3, Line 3905:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">     char cmd[4096];<br>       char cBuf[4096];<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I'd use ast_calloc or ast_asprintf to allocate these.  8K is a little big for the stack.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/6158">change 6158</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/6158"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I07f7052a502457ab55010a4d3686653b60f4c8db </div>
<div style="display:none"> Gerrit-Change-Number: 6158 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Andrey <andr06@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 07 Aug 2017 11:25:23 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>