<p>Kirill Katsnelson <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/6119">View Change</a></p><p>Patch set 2:</p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">A note in the CHANGES file is needed to let people know about the new function.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">Done.</p><p>(5 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/6119/2/channels/chan_sip.c">File channels/chan_sip.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6119/2/channels/chan_sip.c@400">Patch Set #2, Line 400:</a> <code style="font-family:monospace,monospace">                    you may use <literal>${SIP_HEADERS(X-)}</literal> to enumerate optional extended</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Tab in the middle of the line between "may use".</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6119/2/channels/chan_sip.c@23092">Patch Set #2, Line 23092:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">      SCOPED_CHANNELLOCK(chanlock, chan);<br><br> if (!chan) {<br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Using SCOPED_CHANNELLOCK() and then testing if chan is NULL doesn't work.  </blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6119/2/channels/chan_sip.c@23108">Patch Set #2, Line 23108:</a> <code style="font-family:monospace,monospace">  AST_STANDARD_APP_ARGS(args, data);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">This modifies the data string.  The usual code copies to a local string bef</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Oh boy, is not that everywhere around, even in the new(er) code, such as chan_pjsip! Fixed here and in SIP_HEADER() implementation too.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6119/2/channels/chan_sip.c@23115">Patch Set #2, Line 23115:</a> <code style="font-family:monospace,monospace">         if (ast_begins_with(header, args.pattern)) {</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Could check for '*' to mean match any header for compatibility with the REF</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6119/2/channels/chan_sip.c@23119">Patch Set #2, Line 23119:</a> <code style="font-family:monospace,monospace">                          struct ast_str *token = ast_str_alloca(100);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Need to pull the ast_str_alloca() out of the loop because it allocates stac</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/6119">change 6119</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/6119"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I2076d3893d03a2f82429f393b5b46db6cf68a267 </div>
<div style="display:none"> Gerrit-Change-Number: 6119 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Kirill Katsnelson <kkm@smartaction.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Kirill Katsnelson <kkm@smartaction.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 02 Aug 2017 00:18:55 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>