<p>George Joseph <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/6032">View Change</a></p><p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(5 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/6032/2/apps/confbridge/conf_config_parser.c">File apps/confbridge/conf_config_parser.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6032/2/apps/confbridge/conf_config_parser.c@453">Patch Set #2, Line 453:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> <configOption name="video_update_discard" default="2000"><br> <synopsis>Sets the amount of time in milliseconds after sending a video update to discard subsequent video updates</synopsis><br> <description><para><br> Sets the amount of time in milliseconds after sending a video update request<br> that subsequent video updates should be discarded. This means that if we<br> send a video update we will discard any other video update requests until<br> after the configured amount of time has elapsed. This prevents flooding of<br> video update requests from clients.<br> </para></description><br> </configOption><br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">spaces instead of tabs</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/6032/2/configs/samples/confbridge.conf.sample">File configs/samples/confbridge.conf.sample:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6032/2/configs/samples/confbridge.conf.sample@221">Patch Set #2, Line 221:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">;video_update_discard=2000 ; Amount of time (in milliseconds) to discard video update requests after sending a video<br> ; update request. Default is 2000.<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Can you explain a little more about "video update requests"?</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/6032/2/main/rtp_engine.c">File main/rtp_engine.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6032/2/main/rtp_engine.c@3416">Patch Set #2, Line 3416:</a> <code style="font-family:monospace,monospace">}</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Did whitespace get added after the '}'?</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/6032/3/res/res_rtp_asterisk.c">File res/res_rtp_asterisk.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6032/3/res/res_rtp_asterisk.c@3983">Patch Set #3, Line 3983:</a> <code style="font-family:monospace,monospace">difference && </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Let's see if richard marks this as an unnecessary comparison. :)</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6032/3/res/res_rtp_asterisk.c@3990">Patch Set #3, Line 3990:</a> <code style="font-family:monospace,monospace">!difference || difference > 0</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Why not just "difference >= 0" ?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/6032">change 6032</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/6032"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ibd91362f0e4990b6129638e712bc8adf0899fd45 </div>
<div style="display:none"> Gerrit-Change-Number: 6032 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 19 Jul 2017 13:17:43 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>