<p>George Joseph <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/5878">View Change</a></p><p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(4 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/5878/3/tests/channels/pjsip/dtmf_info_fallback/run-test">File tests/channels/pjsip/dtmf_info_fallback/run-test:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5878/3/tests/channels/pjsip/dtmf_info_fallback/run-test@25">Patch Set #3, Line 25:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sippA_logfile = WORKING_DIR + "/A_PARTY.log"<br>sippA_errfile = WORKING_DIR + "/A_PARTY_ERR.log"<br>sippB_logfile = WORKING_DIR + "/B_PARTY.log"<br>sippB_errfile = WORKING_DIR + "/B_PARTY_ERR.log"<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">These cause the working tree to be polluted.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5878/3/tests/channels/pjsip/dtmf_info_fallback/run-test@29">Patch Set #3, Line 29:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">SIPP_SCENARIOS = [<br> {<br> 'scenario' : 'B_PARTY.xml',<br> '-i' : '127.0.0.1',<br> '-p' : '5700',<br> '-mp' : '6300',<br> '-message_file' : sippB_logfile,<br> '-error_file' : sippB_errfile,<br> '-trace_msg' : '-trace_err',<br> },<br> {<br> 'scenario' : 'A_PARTY.xml',<br> '-i' : '127.0.0.1',<br> '-p' : '6060',<br> '-s' : '3228080970',<br> '-d' : '35000',<br> '-message_file' : sippA_logfile,<br> '-error_file' : sippA_errfile,<br> '-trace_msg' : '-trace_err',<br> }<br>]<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Why not just do this in the test-config.yaml file?</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5878/3/tests/channels/pjsip/dtmf_info_fallback/run-test@56">Patch Set #3, Line 56:</a> <code style="font-family:monospace,monospace"> </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">whitespace</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/5878/3/tests/channels/pjsip/dtmf_info_fallback/test-config.yaml">File tests/channels/pjsip/dtmf_info_fallback/test-config.yaml:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5878/3/tests/channels/pjsip/dtmf_info_fallback/test-config.yaml@7">Patch Set #3, Line 7:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> minversion: '13.16.0'<br> dependencies:<br> - app : 'sipp'<br> tags:<br> - SIP<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">This would be better...</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">properties:<br> minversion: [ '13.17.0', '14.6.0' ]<br> dependencies:<br> - app : 'sipp'<br> - asterisk : 'res_pjsip'<br> tags:<br> - pjsip</pre></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/5878">change 5878</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/5878"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I674d3a6dc678f275bb39738505ee032dd86dbb37 </div>
<div style="display:none"> Gerrit-Change-Number: 5878 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Torrey Searle <tsearle@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Matthew Fredrickson <creslin@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 29 Jun 2017 12:58:39 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>