<p>Jan Friesse <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/5859">View Change</a></p><p>Patch set 1:</p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">(1 comment)</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">Yes I can agree it looks like a lot, but calling stack can look like:</p><p style="white-space: pre-wrap; word-wrap: break-word;">dispatch_thread_handler<br>cpg_dispatch (> 1MB stack allocated)<br>cpg_confchg_cb<br>send_cluster_notify<br>corosync_cfg_get_node_addrs (> 1MB stack allocated)</p><p style="white-space: pre-wrap; word-wrap: break-word;">So strictly speaking 2MB + some room should be enough, but I've rather set 3MB just for sure.</p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/5859/1/res/res_corosync.c">File res/res_corosync.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5859/1/res/res_corosync.c@86">Patch Set #1, Line 86:</a> <code style="font-family:monospace,monospace">                (AST_BACKGROUND_STACKSIZE + (3 * COROSYNC_IPC_BUFFER_SIZE)),    \</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Is 3 MB necessary here?  It seems excessive, IMHO.  But maybe that's just m</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Yes I can agree it looks like a lot, but calling stack can look like:</p><p style="white-space: pre-wrap; word-wrap: break-word;">dispatch_thread_handler<br>cpg_dispatch (> 1MB stack allocated)<br>cpg_confchg_cb<br>send_cluster_notify<br>corosync_cfg_get_node_addrs (> 1MB stack allocated)</p><p style="white-space: pre-wrap; word-wrap: break-word;">So strictly speaking 2MB + some room should be enough, but I've rather set 3MB just for sure.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/5859">change 5859</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/5859"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Id95b0d21ab6e708e7d74ad8786c587211676fa08 </div>
<div style="display:none"> Gerrit-Change-Number: 5859 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Jan Friesse <jfriesse@redhat.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jan Friesse <jfriesse@redhat.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Matthew Fredrickson <creslin@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 19 Jun 2017 06:44:41 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>