[Asterisk-code-review] func_groupcount.c: Adding Group Variables + additional Group functions (asterisk[18])

[Mark Murawski]

Attention is currently required from: N A.

Mark Murawski has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17655 )

Change subject: func_groupcount.c: Adding Group Variables + additional Group functions
......................................................................


Patch Set 25:

(5 comments)

File funcs/func_groupcount.c:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/a86068b9_0d2a844d 
PS25, Line 167: 			<example>Find groups containing 'foo': .*foo.*</example>
> The description should go in the title attribute, and you should provide a full example […]
Done


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/5fcf2555_a2dcf6b8 
PS25, Line 234: 			<example title="On Channel 1">
> This description is not descriptive enough
Done


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/aed2c80b_b3aa3c19 
PS25, Line 238: 			<example title="On Channel 2">
> Same with this one, and move the parenthetical inside the title
Done


File main/app.c:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/753bc81d_55da3894 
PS25, Line 217: 	int transfer_fixup:1;                          /*!< Whether we will run a fixup on masquerade */
> This bit exists in 2 places, but I don't see it used anywhere? Can we get rid of it?
Done


File main/cli.c:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/12dd65ee_4200f0d9 
PS25, Line 1967: 
> Change the order here to Group Category Variables, instead of Group Variables Category. […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17655
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I23e48d1cdfc8adaffdfec2e936e56143603914f2
Gerrit-Change-Number: 17655
Gerrit-PatchSet: 25
Gerrit-Owner: Mark Murawski <markm at intellasoft.net>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Comment-Date: Thu, 18 May 2023 22:02:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230518/02431a5a/attachment-0001.html>