[Asterisk-code-review] res_calendar: output busy state as part of show calendar. (asterisk[master])

[N A]

Attention is currently required from: Jaco Kroon.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/20024 )

Change subject: res_calendar: output busy state as part of show calendar.
......................................................................


Patch Set 5:

(3 comments)

Patchset:

PS5: 
A couple minor things I noticed if you feel like addressing them:


File res/res_calendar.c:

https://gerrit.asterisk.org/c/asterisk/+/20024/comment/d4235ca0_719a4a28 
PS5, Line 1611: static const char *ast_calendar_busy_state_to_str(enum ast_calendar_busy_state busy_state)
Why is this ast_ prefixed if it's not API? Could probably just be calendar_busy_state_to_str instead?


https://gerrit.asterisk.org/c/asterisk/+/20024/comment/e865c4c5_01b2e6ed 
PS5, Line 1625: 
There's an unnecessary newline here



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/20024
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I894e4ecc3e93db4ff7783d46266ba3c5e6ccda10
Gerrit-Change-Number: 20024
Gerrit-PatchSet: 5
Gerrit-Owner: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: N A <asterisk at phreaknet.org>
Gerrit-Attention: Jaco Kroon <jaco at uls.co.za>
Gerrit-Comment-Date: Thu, 30 Mar 2023 14:02:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230330/cd1cc745/attachment-0001.html>