[Asterisk-code-review] res_pjsip_pubsub: subscription cleanup changes (asterisk[18])

[N A]

Attention is currently required from: Michael Bradeen, Stanislav Abramenkov.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/20028 )

Change subject: res_pjsip_pubsub: subscription cleanup changes
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

Patchset:

PS2: 
I put this on 2 systems and so far it's working correctly, so thank you for the fuller fix!

I'll update this review if anything goes awry but otherwise seems good to me so far.


File res/res_pjsip_pubsub.c:

https://gerrit.asterisk.org/c/asterisk/+/20028/comment/cd377c03_dbf3cc71 
PS2, Line 3929: 	if(	event->body.tsx_state.type == PJSIP_EVENT_RX_MSG &&
if ( - space is on the wrong side



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/20028
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I05c1d91a44fe28244ae93faa4a2268a3332b5fd7
Gerrit-Change-Number: 20028
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-CC: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Comment-Date: Wed, 29 Mar 2023 22:26:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230329/18f96299/attachment-0001.html>