[Asterisk-code-review] voicemail.conf: Fix incorrect comment about #include. (asterisk[master])

N A asteriskteam at digium.com
Wed Mar 29 13:32:46 CDT 2023


Attention is currently required from: Sean Bright.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/20027 )

Change subject: voicemail.conf: Fix incorrect comment about #include.
......................................................................


Patch Set 2:

(1 comment)

File configs/samples/voicemail.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/20027/comment/60620f44_3b0c2a1d 
PS1, Line 7: ; NOTE: Asterisk has to edit this file to change a user's password.  This
           : ; works with the "#include <file>" directive for Asterisk configuration files,
           : ; but not when using realtime static configuration.
           : ; If your "source of truth" for voicemail passwords is elsewhere, you should
           : ; use the externpassnotify option to keep that synchronized.
> If you're confirmed that both voicemail.conf and files #include'd by voicemail. […]
passwordlocation is good but doesn't address cases where the master copy of the password is not even stored on the machine necessarily, such as in a distributed cluster for example. I've hopefully clarified that a bit.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/20027
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I3bf7d275849ab83f55f7fb6702a75a3077ee1df3
Gerrit-Change-Number: 20027
Gerrit-PatchSet: 2
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Comment-Date: Wed, 29 Mar 2023 18:32:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230329/5b5d9ceb/attachment.html>


More information about the asterisk-code-review mailing list