[Asterisk-code-review] logrotate: Fix duplicate log entries. (asterisk[master])

[Sean Bright]

Attention is currently required from: N A.

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19929 )

Change subject: logrotate: Fix duplicate log entries.
......................................................................


Patch Set 3:

(1 comment)

Patchset:

PS2: 
> After Sean's edit, mm_log would not get rotated anymore, whereas previously it would have been, which is a behavior change.

If you have memory allocation logging enabled long enough that the file needs to be rotated you're doing something wrong. It's intended as a debugging aid. Regardless I have added it explicitly.

Note that since it is not part of the logging system, 'logger reload' will have no affect, so Asterisk will continue to write to the old file.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19929
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ic875ed9d052fe79f4c3bef58d37d65b2231af796
Gerrit-Change-Number: 19929
Gerrit-PatchSet: 3
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Comment-Date: Wed, 29 Mar 2023 13:35:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230329/82eaf8f3/attachment-0001.html>