[Asterisk-code-review] logrotate: Fix duplicate log entries. (asterisk[master])

[N A]

Attention is currently required from: Sean Bright.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19929 )

Change subject: logrotate: Fix duplicate log entries.
......................................................................


Patch Set 2:

(1 comment)

Patchset:

PS2: 
Should this just be __LOGDIR__/*log ?

After Sean's edit, mm_log would not get rotated anymore, whereas previously it would have been, which is a behavior change.

We could add mm_log explicitly, in addition to queue_log, but that just hopes there are others we didn't miss.

Alternately, we could modify astmm.c to also add a .log extension to mm_log. Maybe that would be more appropriate.

Thoughts?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19929
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ic875ed9d052fe79f4c3bef58d37d65b2231af796
Gerrit-Change-Number: 19929
Gerrit-PatchSet: 2
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Comment-Date: Wed, 29 Mar 2023 12:58:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230329/be311e17/attachment.html>