[Asterisk-code-review] loader.c: Minor module key check simplification. (asterisk[master])

Sean Bright asteriskteam at digium.com
Thu Mar 23 10:16:40 CDT 2023


Sean Bright has uploaded this change for review. ( https://gerrit.asterisk.org/c/asterisk/+/20014 )


Change subject: loader.c: Minor module key check simplification.
......................................................................

loader.c: Minor module key check simplification.

Change-Id: I65aefd4434a783096165c179b5f94f2e4810dffe
---
M main/loader.c
1 file changed, 10 insertions(+), 11 deletions(-)



  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/14/20014/1

diff --git a/main/loader.c b/main/loader.c
index 208e5a2..1c06d6e 100644
--- a/main/loader.c
+++ b/main/loader.c
@@ -885,17 +885,7 @@
 	return 0;
 }
 
-static int key_matches(const unsigned char *key1, const unsigned char *key2)
-{
-	int x;
-
-	for (x = 0; x < 16; x++) {
-		if (key1[x] != key2[x])
-			return 0;
-	}
-
-	return 1;
-}
+#define key_matches(a, b) (memcmp((a), (b), 16) == 0)
 
 static int verify_key(const unsigned char *key)
 {

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/20014
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I65aefd4434a783096165c179b5f94f2e4810dffe
Gerrit-Change-Number: 20014
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230323/4d83a3e1/attachment.html>


More information about the asterisk-code-review mailing list