[Asterisk-code-review] res_calendar: output busy state as part of show calendar. (asterisk[master])

[Jaco Kroon]

Attention is currently required from: Sean Bright.

Jaco Kroon has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/20024 )

Change subject: res_calendar: output busy state as part of show calendar.
......................................................................


Patch Set 3:

(2 comments)

File include/asterisk/calendar.h:

https://gerrit.asterisk.org/c/asterisk/+/20024/comment/d6d80853_2a795380 
PS3, Line 207:  * \param The busy_state value to obtain a string for.
> This is not the correct doxygen syntax. […]
facepalm!


File res/res_calendar.c:

https://gerrit.asterisk.org/c/asterisk/+/20024/comment/2573a4d9_1d0872d3 
PS2, Line 369: default:
             : 		return NULL;
> > Elsewhere in the code BUSYSTATE comes from what I would consider an "untrusted source" and is proc […]
I contemplated this, and decided against that since if *other* future users use the function I'd prefer for them to be able to differentiate between a valid and invalid response.  Don't feel particularly strong, so if you think that's better, happy to update as such.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/20024
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I894e4ecc3e93db4ff7783d46266ba3c5e6ccda10
Gerrit-Change-Number: 20024
Gerrit-PatchSet: 3
Gerrit-Owner: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Comment-Date: Thu, 23 Mar 2023 14:40:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: Jaco Kroon <jaco at uls.co.za>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230323/726ee7a1/attachment.html>