[Asterisk-code-review] res_calendar: output busy state as part of show calendar. (asterisk[master])

[Jaco Kroon]

Attention is currently required from: Sean Bright.

Jaco Kroon has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/20024 )

Change subject: res_calendar: output busy state as part of show calendar.
......................................................................


Patch Set 2:

(3 comments)

File include/asterisk/calendar.h:

https://gerrit.asterisk.org/c/asterisk/+/20024/comment/4a09d591_ae3e93c7 
PS2, Line 207: const char* ast_calendar_busy_state_to_str(enum ast_calendar_busy_state busy_state);
> There should be a space before the `*` and not after. […]
Done


File res/res_calendar.c:

https://gerrit.asterisk.org/c/asterisk/+/20024/comment/f1e64d45_05b7ea16 
PS2, Line 360: const char* ast_calendar_busy_state_to_str(enum ast_calendar_busy_state busy_state)
> There should be a space before the `*` and not after.
Done


https://gerrit.asterisk.org/c/asterisk/+/20024/comment/b5702cc3_3cc2e530 
PS2, Line 369: default:
             : 		return NULL;
> If `busy_state` can be something other than the 3 defined values I would argue that is a bug that sh […]
Elsewhere in the code BUSYSTATE comes from what I would consider an "untrusted source" and is processed with atol(), so what if BUSYSTATE:-1 or BUSYSTATE:3 comes our way?  What if the specification (unlikely) gets expanded?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/20024
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I894e4ecc3e93db4ff7783d46266ba3c5e6ccda10
Gerrit-Change-Number: 20024
Gerrit-PatchSet: 2
Gerrit-Owner: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Comment-Date: Thu, 23 Mar 2023 14:16:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230323/206bc81e/attachment.html>