[Asterisk-code-review] install_prereq: Add Linux Mint support. (asterisk[master])

[Sean Bright]

Attention is currently required from: Martin McCarthy.

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19974 )

Change subject: install_prereq: Add Linux Mint support.
......................................................................


Patch Set 3: Code-Review-1

(9 comments)

Patchset:

PS3: 
There are still some packages being added that shouldn't be.

It's very obvious when you look at the diff:

https://gerrit.asterisk.org/c/asterisk/+/19974/3/contrib/scripts/install_prereq


File contrib/scripts/install_prereq:

https://gerrit.asterisk.org/c/asterisk/+/19974/comment/be837086_81beb7a3 
PS3, Line 28: PACKAGES_DEBIAN="$PACKAGES_DEBIAN libmysqlclient-dev libbluetooth-dev libradcli-dev freetds-dev libosptk-dev libjack-jackd2-dev bash libcap-dev"
Remove `libosptk-dev`


https://gerrit.asterisk.org/c/asterisk/+/19974/comment/6c969286_5bc66209 
PS3, Line 42: PACKAGES_RH="$PACKAGES_RH speex-devel speexdsp-devel libogg-devel libvorbis-devel alsa-lib-devel portaudio-devel libcurl-devel xmlstarlet bison flex"
Remove `alsa-lib-devel`


https://gerrit.asterisk.org/c/asterisk/+/19974/comment/3f7fc23b_a2c13e2f 
PS3, Line 58: PACKAGES_SUSE="$PACKAGES_SUSE speex-devel speexdsp-devel libogg-devel libvorbis-devel alsa-devel portaudio-devel libcurl-devel xmlstarlet bison flex"
Remove `alsa-devel`


https://gerrit.asterisk.org/c/asterisk/+/19974/comment/760f6e20_4426c45a 
PS3, Line 74: PACKAGES_ARCH="$PACKAGES_ARCH speex speexdsp libogg libvorbis alsa-lib portaudio curl xmlstarlet bison flex"
Remove `alsa-lib`


https://gerrit.asterisk.org/c/asterisk/+/19974/comment/e2019861_e84c2628 
PS3, Line 90: PACKAGES_GENTOO="$PACKAGES_GENTOO media-libs/speex media-libs/speexdsp media-libs/libogg media-libs/libvorbis media-libs/alsa-lib media-libs/portaudio net-misc/curl app-text/xmlstarlet sys-devel/bison sys-devel/flex"
Remove `media-libs/alsa-libs`


https://gerrit.asterisk.org/c/asterisk/+/19974/comment/ca2db3bb_0ef87054 
PS3, Line 106: PACKAGES_NBSD="$PACKAGES_NBSD speex speexdsp libogg libvorbis alsa-lib portaudio-devel curl bison flex"
Remove `alsa-lib`


https://gerrit.asterisk.org/c/asterisk/+/19974/comment/0ad902bd_0145b318 
PS3, Line 138: PACKAGES_FBSD="$PACKAGES_FBSD speex speexdsp libogg libvorbis alsa-lib portaudio curl xmlstarlet bison flex"
Remove `alsa-lib`


https://gerrit.asterisk.org/c/asterisk/+/19974/comment/8d9cde46_361214c2 
PS3, Line 154: PACKAGES_DBSD="$PACKAGES_DBSD speex speexdsp libogg libvorbis alsa-lib portaudio curl xmlstarlet bison flex"
Remove `alsa-lib`



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19974
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I9c140c7f12ca7dafe65c317f2a26122cf2c72556
Gerrit-Change-Number: 19974
Gerrit-PatchSet: 3
Gerrit-Owner: Martin McCarthy <martin.c.mccarthy at outlook.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Martin McCarthy <martin.c.mccarthy at outlook.com>
Gerrit-Comment-Date: Thu, 16 Mar 2023 22:28:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230316/bfd83f7e/attachment.html>