[Asterisk-code-review] install_prereq: Add Linux Mint support. (asterisk[master])

[Martin McCarthy]

Attention is currently required from: Sean Bright.

Martin McCarthy has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19974 )

Change subject: install_prereq: Add Linux Mint support.
......................................................................


Patch Set 2:

(6 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/19974/comment/ddc0bfd4_67fb9e2b 
PS2, Line 7: contrib/scripts/install_prereq.sh - added Linux Mint support.
> Use `install_prereq: Add Linux Minute support.` here. […]
Ack


Patchset:

PS2: 
Changes done. Thanks Sean.


File contrib/scripts/install_prereq:

https://gerrit.asterisk.org/c/asterisk/+/19974/comment/67c455b2_f93f0b86 
PS2, Line 8: # Linux Mint support added by Martin McCarthy 2023-03-16 14:48:15
> Don't include this. Source control tracks all of this for us.
Ack


https://gerrit.asterisk.org/c/asterisk/+/19974/comment/21f32696_2d9ab35e 
PS2, Line 14: echo "Support distros; Debian, RHEL, openSUSE, Gentoo, Arch Linux"
            : 	echo "NetBSD, OpenBSD, FreeBSD and Dragonfly BSD"
> Remove this
Ack


https://gerrit.asterisk.org/c/asterisk/+/19974/comment/bb10e030_0e5f36a1 
PS2, Line 286: 		missing_package_check=$(apt list --installed 2>/dev/null | grep  $package | wc -l)
> You can use `grep -c` here to avoid the call to `wc`: […]
This is handy to know. Thanks Sean.


https://gerrit.asterisk.org/c/asterisk/+/19974/comment/d18da241_98660fd2 
PS2, Line 448: 
             : 		echo "We've detected you're using Linux Mint. Welcome Minty one."
             : 		echo ""
> Remove these `echo`s
Ack



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19974
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I9c140c7f12ca7dafe65c317f2a26122cf2c72556
Gerrit-Change-Number: 19974
Gerrit-PatchSet: 2
Gerrit-Owner: Martin McCarthy <martin.c.mccarthy at outlook.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Comment-Date: Thu, 16 Mar 2023 20:10:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230316/b0b8761d/attachment.html>