[Asterisk-code-review] contrib/scripts/install_prereq.sh - added Linux Mint support. (asterisk[master])

[Sean Bright]

Attention is currently required from: Martin McCarthy.

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19974 )

Change subject: contrib/scripts/install_prereq.sh - added Linux Mint support.
......................................................................


Patch Set 2: Code-Review-1

(5 comments)

Patchset:

PS2: 
In addition to the comments below, it looks like you're modifying the package list for the other distros (mainly adding alsa-lib-dev to them). All of that should be reverted unless it is specifically related to adding Linux Mint support.


File contrib/scripts/install_prereq:

https://gerrit.asterisk.org/c/asterisk/+/19974/comment/2c6a9043_d2f3370d 
PS2, Line 8: # Linux Mint support added by Martin McCarthy 2023-03-16 14:48:15
Don't include this. Source control tracks all of this for us.


https://gerrit.asterisk.org/c/asterisk/+/19974/comment/29b658ae_fa6396aa 
PS2, Line 14: echo "Support distros; Debian, RHEL, openSUSE, Gentoo, Arch Linux"
            : 	echo "NetBSD, OpenBSD, FreeBSD and Dragonfly BSD"
Remove this


https://gerrit.asterisk.org/c/asterisk/+/19974/comment/cc89d165_9c8ac9ef 
PS2, Line 286: 		missing_package_check=$(apt list --installed 2>/dev/null | grep  $package | wc -l)
You can use `grep -c` here to avoid the call to `wc`:

 missing_package_check=$(apt list --installed 2>/dev/null | grep -c $package)


https://gerrit.asterisk.org/c/asterisk/+/19974/comment/be21474f_e05be096 
PS2, Line 448: 
             : 		echo "We've detected you're using Linux Mint. Welcome Minty one."
             : 		echo ""
Remove these `echo`s



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19974
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I9c140c7f12ca7dafe65c317f2a26122cf2c72556
Gerrit-Change-Number: 19974
Gerrit-PatchSet: 2
Gerrit-Owner: Martin McCarthy <martin.c.mccarthy at outlook.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Martin McCarthy <martin.c.mccarthy at outlook.com>
Gerrit-Comment-Date: Thu, 16 Mar 2023 18:20:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230316/4f7eed09/attachment-0001.html>