[Asterisk-code-review] contrib/scripts/install_prereq.sh - added Linux Mint support. (asterisk[master])

Sean Bright asteriskteam at digium.com
Thu Mar 16 12:02:44 CDT 2023


Attention is currently required from: Martin McCarthy.

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19974 )

Change subject: contrib/scripts/install_prereq.sh - added Linux Mint support.
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/19974/comment/f81ee0dc_cef42cf5 
PS1, Line 7: contrib/scripts/install_prereq.sh - added Linux Mint support.
`install_prereq: Add Linux Mint support.`


https://gerrit.asterisk.org/c/asterisk/+/19974/comment/436ee2c3_3ff8f6e4 
PS1, Line 9: List of Changes;
           : 
           : - added Linux Mint support.
This adds no value beyond what is in the summary line so you can exclude it.


Patchset:

PS1: 
This changes to `install_prereq` should be the absolute minimum required to facilitate Linux Mint support. That means adding the `handle_linuxmint` function and calling it from the appropriate place.

All of the other commingled changes serve only to make the functional changes that much harder to review.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19974
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I9c140c7f12ca7dafe65c317f2a26122cf2c72556
Gerrit-Change-Number: 19974
Gerrit-PatchSet: 1
Gerrit-Owner: Martin McCarthy <martin.c.mccarthy at outlook.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Martin McCarthy <martin.c.mccarthy at outlook.com>
Gerrit-Comment-Date: Thu, 16 Mar 2023 17:02:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230316/161e2bf1/attachment.html>


More information about the asterisk-code-review mailing list