[Asterisk-code-review] app_dial: Fix DTMF not relayed to caller on unanswered calls. (asterisk[18])

Joshua Colp asteriskteam at digium.com
Thu Mar 16 10:41:30 CDT 2023


Joshua Colp has submitted this change. ( https://gerrit.asterisk.org/c/asterisk/+/19980 )

Change subject: app_dial: Fix DTMF not relayed to caller on unanswered calls.
......................................................................

app_dial: Fix DTMF not relayed to caller on unanswered calls.

DTMF frames are not handled in app_dial when sent towards the
caller. This means that if DTMF is sent to the calling party
and the call has not yet been answered, the DTMF is not audible.
This is now fixed by relaying DTMF frames if only a single
destination is being dialed.

ASTERISK-29516 #close

Change-Id: Iafd7430ac2915126d42dc48f0b73b262452ee027
---
M apps/app_dial.c
1 file changed, 19 insertions(+), 0 deletions(-)

Approvals:
  Joshua Colp: Looks good to me, but someone else must approve; Approved for Submit
  George Joseph: Looks good to me, approved




diff --git a/apps/app_dial.c b/apps/app_dial.c
index c389225..44769de 100644
--- a/apps/app_dial.c
+++ b/apps/app_dial.c
@@ -1762,6 +1762,8 @@
 			case AST_FRAME_VIDEO:
 			case AST_FRAME_VOICE:
 			case AST_FRAME_IMAGE:
+			case AST_FRAME_DTMF_BEGIN:
+			case AST_FRAME_DTMF_END:
 				if (caller_entertained) {
 					break;
 				}

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19980
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Iafd7430ac2915126d42dc48f0b73b262452ee027
Gerrit-Change-Number: 19980
Gerrit-PatchSet: 2
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230316/c24d9b34/attachment-0001.html>


More information about the asterisk-code-review mailing list