[Asterisk-code-review] res_mixmonitor: MixMonitorMute by MixMonitor ID (asterisk[18])

Joshua Colp asteriskteam at digium.com
Tue Mar 14 13:33:30 CDT 2023


Attention is currently required from: Michael Bradeen.

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19969 )

Change subject: res_mixmonitor: MixMonitorMute by MixMonitor ID
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

File doc/CHANGES-staging/app_mixmonitor_mute_by_id.txt:

https://gerrit.asterisk.org/c/asterisk/+/19969/comment/ebf22b23_0019a832 
PS3, Line 15: As part of this change, if no MixMonitorID is specified in
This is a behavior change. What was the previous behavior? If it was undefined/unpredictable I think this is fine. If it was predictable before, I'm kind of thinking it should remain as it was with an optional "all" instead.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19969
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Ibba8c7e750577aa1595a24b23316ef445245be98
Gerrit-Change-Number: 19969
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Comment-Date: Tue, 14 Mar 2023 18:33:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230314/c86d8b4e/attachment.html>


More information about the asterisk-code-review mailing list