[Asterisk-code-review] res_musiconhold: Add option to loop last file. (asterisk[master])
N A
asteriskteam at digium.com
Mon Mar 13 19:05:50 CDT 2023
Attention is currently required from: Sean Bright.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19968 )
Change subject: res_musiconhold: Add option to loop last file.
......................................................................
Patch Set 2:
(2 comments)
File configs/samples/musiconhold.conf.sample:
https://gerrit.asterisk.org/c/asterisk/+/19968/comment/0f62d38e_bddee163
PS1, Line 85: looplast
> Let's go with loop_last instead. This will need updating everywhere.
I only went with looplast for consistency with the existing nomenclature, but fine with me.
https://gerrit.asterisk.org/c/asterisk/+/19968/comment/e7258940_581bee04
PS1, Line 88: Typically
> "Typically" doesn't make sense when referring to a new option, so maybe "Can be" instead.
Done
--
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19968
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I5d49058f1b0647238809936e279868e98aeb3dfb
Gerrit-Change-Number: 19968
Gerrit-PatchSet: 2
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Comment-Date: Tue, 14 Mar 2023 00:05:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230314/ce0c6151/attachment-0001.html>
More information about the asterisk-code-review
mailing list