[Asterisk-code-review] bridge_builtin_features: add beep via touch variable (asterisk[18])

Michael Bradeen asteriskteam at digium.com
Mon Mar 13 16:12:09 CDT 2023


Attention is currently required from: Michael Bradeen, Sean Bright, N A.

Hello Sean Bright, Joshua Colp, N A, Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/19934

to look at the new patch set (#5).

Change subject: bridge_builtin_features: add beep via touch variable
......................................................................

bridge_builtin_features: add beep via touch variable

Add periodic beep option to one-touch recording by setting
the touch variable TOUCH_MONITOR_BEEP or
TOUCH_MIXMONITOR_BEEP to the desired interval in seconds.

If the interval is less than 5 seconds, a minimum of 5
seconds will be imposed.  If the interval is set to an
invalid value, it will default to 15 seconds.

A new test event PERIODIC_HOOK_ENABLED was added to the
func_periodic_hook hook_on function to indicate when
a hook is started.  This is so we can test that the touch
variable starts the hook as expected.

ASTERISK-30446

Change-Id: I800e494a789ba7a930bbdcd717e89d86040d6661
---
M bridges/bridge_builtin_features.c
A doc/CHANGES-staging/bridge_builtin_features_beep_on_monitor.txt
M funcs/func_periodic_hook.c
M main/features_config.c
4 files changed, 97 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/34/19934/5
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19934
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I800e494a789ba7a930bbdcd717e89d86040d6661
Gerrit-Change-Number: 19934
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230313/fb18d5bf/attachment.html>


More information about the asterisk-code-review mailing list