[Asterisk-code-review] res_musiconhold: Add option to loop last file. (asterisk[master])

Sean Bright asteriskteam at digium.com
Mon Mar 13 14:46:56 CDT 2023


Attention is currently required from: N A.

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19968 )

Change subject: res_musiconhold: Add option to loop last file.
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

Patchset:

PS1: 
This requires alembic migrations as well.


File configs/samples/musiconhold.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/19968/comment/7f411735_58fbf393 
PS1, Line 85: looplast
Let's go with loop_last instead. This will need updating everywhere.


https://gerrit.asterisk.org/c/asterisk/+/19968/comment/54d397e8_59f28055 
PS1, Line 88: Typically 
"Typically" doesn't make sense when referring to a new option, so maybe "Can be" instead.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19968
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I5d49058f1b0647238809936e279868e98aeb3dfb
Gerrit-Change-Number: 19968
Gerrit-PatchSet: 1
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Comment-Date: Mon, 13 Mar 2023 19:46:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230313/4d4db11d/attachment.html>


More information about the asterisk-code-review mailing list