[Asterisk-code-review] res_pjsip_stir_shaken: Fix JSON field ordering and disallowed TN char... (asterisk[master])

[Sean Bright]

Attention is currently required from: N A, Joshua Colp.

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19897 )

Change subject: res_pjsip_stir_shaken: Fix JSON field ordering and disallowed TN characters.
......................................................................


Patch Set 8: Code-Review-1

(2 comments)

File res/ari/cli.c:

https://gerrit.asterisk.org/c/asterisk/+/19897/comment/4efef48f_006284c5 
PS8, Line 63: switch (conf->general->format) {
            : 	case AST_JSON_COMPACT:
            : 		ast_cli(a->fd, "compact");
            : 		break;
            : 	case AST_JSON_PRETTY:
            : 		ast_cli(a->fd, "pretty");
            : 		break;
            : 	case AST_JSON_SORTED:
            : 		ast_cli(a->fd, "sorted");
            : 		break;
            : 	}
Because we're retroactively making these things flags (and seeing as conf->general->format can never actually be "sorted")

 if (conf->general->format & AST_JSON_PRETTY) {
   ast_cli(a->fd, "pretty");
 } else {
   ast_cli(a->fd, "compact");
 }


File res/res_pjsip_stir_shaken.c:

https://gerrit.asterisk.org/c/asterisk/+/19897/comment/2b902a19_96d2eab4 
PS8, Line 407: 		char *new = dest_tn;
Don't use `new` as an identifier as it's a C++ keyword and can confuse the code highlighter and maybe even some really old compilers.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19897
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iab76d39447c4b8cf133de85657dba02fda07f9a2
Gerrit-Change-Number: 19897
Gerrit-PatchSet: 8
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 08 Mar 2023 22:21:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230308/ec660d99/attachment.html>