[Asterisk-code-review] pbx_dundi: Add PJSIP support. (asterisk[master])

N A asteriskteam at digium.com
Wed Mar 8 09:48:10 CST 2023


Attention is currently required from: Joshua Colp.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19702 )

Change subject: pbx_dundi: Add PJSIP support.
......................................................................


Patch Set 6:

(1 comment)

File include/asterisk/dundi.h:

https://gerrit.asterisk.org/c/asterisk/+/19702/comment/d627f35f_9121b4f7 
PS6, Line 63: 	DUNDI_PROTO_PJSIP = 4,
> If from a protocol level it will always be DUNDI_PROTO_SIP, why does PJSIP need to be here?
It's still used internally when parsing whether the user wants to use PJSIP or SIP for connections, even though it can't be requested explicitly by the remote end.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19702
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I2e28e5a5d007bd49e3df113ad567b011103899bf
Gerrit-Change-Number: 19702
Gerrit-PatchSet: 6
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 08 Mar 2023 15:48:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230308/6e89b434/attachment-0001.html>


More information about the asterisk-code-review mailing list