[Asterisk-code-review] install_prereq: Refactoring and enhancements. (asterisk[master])

Sean Bright asteriskteam at digium.com
Tue Mar 7 18:12:57 CST 2023


Attention is currently required from: Mark Murawski, Martin McCarthy.

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19939 )

Change subject: install_prereq: Refactoring and enhancements.
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

Patchset:

PS2: 
After making the change below, install `shellcheck` and run it against `install_prereq`.


File contrib/scripts/install_prereq:

https://gerrit.asterisk.org/c/asterisk/+/19939/comment/5375a3c2_eb0ca56f 
PS2, Line 695: eq
This should be `-eq`



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19939
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I4bd53ae429e113a76d13a23b48da714a8eefad26
Gerrit-Change-Number: 19939
Gerrit-PatchSet: 2
Gerrit-Owner: Martin McCarthy <martin.c.mccarthy at outlook.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Mark Murawski <markm at intellasoft.net>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Mark Murawski <markm at intellasoft.net>
Gerrit-Attention: Martin McCarthy <martin.c.mccarthy at outlook.com>
Gerrit-Comment-Date: Wed, 08 Mar 2023 00:12:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230308/ecbfa590/attachment.html>


More information about the asterisk-code-review mailing list