[Asterisk-code-review] bridge_builtin_features: add beep via touch variable (asterisk[18])

[N A]

Attention is currently required from: Michael Bradeen, Sean Bright.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19934 )

Change subject: bridge_builtin_features: add beep via touch variable
......................................................................


Patch Set 4:

(3 comments)

File bridges/bridge_builtin_features.c:

https://gerrit.asterisk.org/c/asterisk/+/19934/comment/7b850d8b_5dc0a148 
PS3, Line 213: 			if (interval < 5) {
> I think there should be a warning if the interval is reset to 5 silently, so the user can fix the di […]
Done


https://gerrit.asterisk.org/c/asterisk/+/19934/comment/7a70c031_42be5d0e 
PS3, Line 416: 		}
> Shouldn't checking the value of interval be done for MixMonitor just like with Monitor? e.g. […]
Done


File bridges/bridge_builtin_features.c:

https://gerrit.asterisk.org/c/asterisk/+/19934/comment/7393a348_1b4f7f70 
PS4, Line 220: 				ast_log(LOG_WARNING, "Unable to enable periodic beep, please ensure func_periodic_hook is loaded.\n");
This could probably be an ERROR instead of a WARNING



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19934
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I800e494a789ba7a930bbdcd717e89d86040d6661
Gerrit-Change-Number: 19934
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Comment-Date: Tue, 07 Mar 2023 21:00:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230307/5893d7f4/attachment.html>