[Asterisk-code-review] func_groupcount.c: Adding Group Variables + additional Group functions (asterisk[18])

[N A]

Attention is currently required from: Mark Murawski.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17655 )

Change subject: func_groupcount.c: Adding Group Variables + additional Group functions
......................................................................


Patch Set 25:

(2 comments)

File main/app.c:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/5f74619e_712d3e24 
PS25, Line 217: 	int transfer_fixup:1;                          /*!< Whether we will run a fixup on masquerade */
This bit exists in 2 places, but I don't see it used anywhere? Can we get rid of it?


File main/cli.c:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/1ae92d83_7cbbcbd4 
PS25, Line 1967: 
Change the order here to Group Category Variables, instead of Group Variables Category.

This will deal better with long var=value strings. You can specify a width for the group name and category name but the variable assignments can just be %s=%s.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17655
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I23e48d1cdfc8adaffdfec2e936e56143603914f2
Gerrit-Change-Number: 17655
Gerrit-PatchSet: 25
Gerrit-Owner: Mark Murawski <markm at intellasoft.net>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Mark Murawski <markm at intellasoft.net>
Gerrit-Comment-Date: Sat, 04 Mar 2023 00:59:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230304/fff44681/attachment-0001.html>