[Asterisk-code-review] res/res_config_pgsql, Permit more than one database and set parameters. (asterisk[master])

N A asteriskteam at digium.com
Fri Mar 3 14:29:41 CST 2023


Attention is currently required from: Joshua Colp, Eric Dantie.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19921 )

Change subject: res/res_config_pgsql, Permit more than one database and set parameters.
......................................................................


Patch Set 11: Code-Review-1

(3 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/19921/comment/015fae33_5ff4d0b3 
PS10, Line 7: res/res_config_pgsql permit more than one database.
> Comma needed after res_config_pgsql. […]
Sorry, my bad this time, I meant colon, not a comma.

res_config_pgsql: Permit more than one database.


File configs/samples/res_pgsql.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/19921/comment/7546b5e4_2a71064e 
PS11, Line 9: ; - With the other parameters dbhost, ...
It's a little unclear where you're going with the ellipses here


File res_config_pgsql.txt:

https://gerrit.asterisk.org/c/asterisk/+/19921/comment/126a71ce_83ac7cc5 
PS10, Line 1: Subject: Add support for multiples databases
> The subject for CHANGES entries should be the name of the module. […]
As well, this needs to go in doc/CHANGES-staging



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19921
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I9ca8705c96acdd4a10989d981a5c2583a160aa44
Gerrit-Change-Number: 19921
Gerrit-PatchSet: 11
Gerrit-Owner: Eric Dantie <edantie at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Eric Dantie <edantie at gmail.com>
Gerrit-Comment-Date: Fri, 03 Mar 2023 20:29:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230303/3830b288/attachment.html>


More information about the asterisk-code-review mailing list