[Asterisk-code-review] res/res_config_pgsql permit more than one database. (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp, Eric Dantie.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19921 )

Change subject: res/res_config_pgsql permit more than one database.
......................................................................


Patch Set 10: Code-Review-1

(3 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/19921/comment/88703667_12fc0994 
PS10, Line 7: res/res_config_pgsql permit more than one database.
Comma needed after res_config_pgsql.
Permit should be capitalized.


File configs/samples/res_pgsql.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/19921/comment/ddbf46f5_f963cecc 
PS10, Line 8: ;
It should be specified here how the configuration works when dburi is specified and how it interacts with other settings, since this just appeared out of nowhere here.

The paragraph above would be a good place to add this.


File res_config_pgsql.txt:

https://gerrit.asterisk.org/c/asterisk/+/19921/comment/62272080_cdac877c 
PS10, Line 1: Subject: Add support for multiples databases
The subject for CHANGES entries should be the name of the module.
The details can go in the description.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19921
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I9ca8705c96acdd4a10989d981a5c2583a160aa44
Gerrit-Change-Number: 19921
Gerrit-PatchSet: 10
Gerrit-Owner: Eric Dantie <edantie at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Eric Dantie <edantie at gmail.com>
Gerrit-Comment-Date: Thu, 02 Mar 2023 12:53:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230302/080cbb5a/attachment.html>