[Asterisk-code-review] app_read: add option to return terminator on empty digits (asterisk[18])

[Michael Bradeen]

Attention is currently required from: N A.

Michael Bradeen has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19883 )

Change subject: app_read: add option to return terminator on empty digits
......................................................................


Patch Set 1:

(3 comments)

File apps/app_read.c:

https://gerrit.asterisk.org/c/asterisk/+/19883/comment/36978c1b_c1fd33ee 
PS1, Line 91: 					</option>
> The JIRA issue says "This can allow for more distinction between timeouts and specifically chosen em […]
I modified the comment to explain the scenario to the best of my knowledge on it's use case.


https://gerrit.asterisk.org/c/asterisk/+/19883/comment/7da7195b_42916c9a 
PS1, Line 272: 				}
> else should be on the same line
Done


https://gerrit.asterisk.org/c/asterisk/+/19883/comment/9a7b6e95_e5f2724b 
PS1, Line 283: 				}
> Same here, I know you added braces but the else should be on the same line as the closing brace of p […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19883
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I49f3221824330a193a20c660f99da0f1fc2cbbc5
Gerrit-Change-Number: 19883
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Comment-Date: Tue, 31 Jan 2023 19:49:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230131/7bea0708/attachment.html>