[Asterisk-code-review] app_directory: add skip call option (asterisk[18])

George Joseph asteriskteam at digium.com
Mon Jan 30 06:42:01 CST 2023


Attention is currently required from: Michael Bradeen.

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19798 )

Change subject: app_directory: add skip call option
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

File apps/app_directory.c:

https://gerrit.asterisk.org/c/asterisk/+/19798/comment/72ca4e92_f834a3e7 
PS1, Line 138: 			<para>If the skip calling option is set, this application will also set the following
             : 			channel variable, provided an extension is selected:</para>
             : 			<variablelist>
             : 				<variable name="DIRECTORY_EXTEN">
             : 					<para>Extension selected.</para>
             : 				</variable>
             : 			</variablelist>
Why not just add this to the existing variablelist above?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19798
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Ib9d9db1ba5b7524594c640461b4aa8f752db8299
Gerrit-Change-Number: 19798
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Comment-Date: Mon, 30 Jan 2023 12:42:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230130/9ff8dd83/attachment.html>


More information about the asterisk-code-review mailing list