[Asterisk-code-review] app_queue: add option to connect agents only to longest waiting queue... (asterisk[master])

[N A]

Attention is currently required from: Nathan Bruning.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19793 )

Change subject: app_queue: add option to connect agents only to longest waiting queue caller
......................................................................


Patch Set 2: Code-Review-1

(8 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/19793/comment/36a46298_508ee4f4 
PS1, Line 7: res_queue: add option to connect agents only to longest waiting queue caller
> The module is app_queue, not res_queue
Done


https://gerrit.asterisk.org/c/asterisk/+/19793/comment/f28cbdbf_dd52c0a8 
PS1, Line 9: This adds an option 'force_longest_waiting_caller' which can be enabled per queue,
> Wrap the commit message at 72 characters to prevent wrapping
Done


File apps/app_queue.c:

https://gerrit.asterisk.org/c/asterisk/+/19793/comment/84877c37_258b1141 
PS1, Line 4562: 				ast_debug(1, "Found matching member %s in queue '%s'\n", mem->interface, q->name);
> Maybe make this debug level 2, since there could be a lot of these?
Done


https://gerrit.asterisk.org/c/asterisk/+/19793/comment/071556ab_6f2234d2 
PS1, Line 4563: 				
> trailing whitespace
Done


https://gerrit.asterisk.org/c/asterisk/+/19793/comment/396e28a3_4d868486 
PS1, Line 4654: 	
> trailing whitespace
Done


File apps/app_queue.c:

https://gerrit.asterisk.org/c/asterisk/+/19793/comment/005cad87_0ed73a94 
PS2, Line 9495: force_longest_waiting_caller 
This seems like an odd place to set a default.
Why not in queue_reset_global_params instead?


File configs/samples/queues.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/19793/comment/6f775c09_1566872d 
PS1, Line 58: ; call is not offered to the agent.
> Also specify the default value (e.g. […]
Done


File doc/CHANGES-staging/app_queue_force_longest_waiting_caller.txt:

https://gerrit.asterisk.org/c/asterisk/+/19793/comment/67586eed_7d8c6fb3 
PS1, Line 7: caller's perspective.
> Add newline at EOF
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19793
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I4a8e4c21c60639c214114fc909226c175a8849f9
Gerrit-Change-Number: 19793
Gerrit-PatchSet: 2
Gerrit-Owner: Nathan Bruning <nathan at iperity.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: Nathan Bruning <nathan at iperity.com>
Gerrit-Comment-Date: Fri, 27 Jan 2023 12:05:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230127/fc5dbeba/attachment-0001.html>