[Asterisk-code-review] res_queue: add option to connect agents only to longest waiting queue... (asterisk[master])

[N A]

Attention is currently required from: Nathan Bruning.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19793 )

Change subject: res_queue: add option to connect agents only to longest waiting queue caller
......................................................................


Patch Set 1: Code-Review-1

(7 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/19793/comment/b3184a52_c1a455d0 
PS1, Line 7: res_queue: add option to connect agents only to longest waiting queue caller
The module is app_queue, not res_queue


https://gerrit.asterisk.org/c/asterisk/+/19793/comment/42692cb4_f6a31074 
PS1, Line 9: This adds an option 'force_longest_waiting_caller' which can be enabled per queue,
Wrap the commit message at 72 characters to prevent wrapping


File apps/app_queue.c:

https://gerrit.asterisk.org/c/asterisk/+/19793/comment/13f17f6f_b32606f3 
PS1, Line 4562: 				ast_debug(1, "Found matching member %s in queue '%s'\n", mem->interface, q->name);
Maybe make this debug level 2, since there could be a lot of these?


https://gerrit.asterisk.org/c/asterisk/+/19793/comment/f90580f6_8d103766 
PS1, Line 4563: 				
trailing whitespace


https://gerrit.asterisk.org/c/asterisk/+/19793/comment/dcce226c_0eeae9be 
PS1, Line 4654: 	
trailing whitespace


File configs/samples/queues.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/19793/comment/9dedb120_f0400e02 
PS1, Line 58: ; call is not offered to the agent.
Also specify the default value (e.g. "The default value is no")


File doc/CHANGES-staging/app_queue_force_longest_waiting_caller.txt:

https://gerrit.asterisk.org/c/asterisk/+/19793/comment/50ddcea5_3d898953 
PS1, Line 7: caller's perspective.
Add newline at EOF



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19793
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I4a8e4c21c60639c214114fc909226c175a8849f9
Gerrit-Change-Number: 19793
Gerrit-PatchSet: 1
Gerrit-Owner: Nathan Bruning <nathan at iperity.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: Nathan Bruning <nathan at iperity.com>
Gerrit-Comment-Date: Wed, 25 Jan 2023 01:21:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230125/55ebd0cf/attachment-0001.html>