[Asterisk-code-review] res_pjsip: mediasec: Add Security-Client headers after 401 (asterisk[18])

Stanislav Abramenkov asteriskteam at digium.com
Mon Jan 23 02:33:26 CST 2023


Attention is currently required from: Joshua Colp, Maximilian Fridrich.

Stanislav Abramenkov has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19740 )

Change subject: res_pjsip: mediasec: Add Security-Client headers after 401
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

Patchset:

PS2: 
I think that we need to make a small change in module description:
> module show like RFC
Module                         Description                              Use Count  Status      Support Level
res_pjsip_rfc3326.so           PJSIP RFC3326 Support                    0          Running              core
res_pjsip_rfc3329.so           PJSIP RFC 3329 Support (partial)         0          Running              core
2 modules loaded

It should be more similar(standardized). As module "res_pjsip_rfc3326" description is without space, then module "res_pjsip_rfc3329" description should also be without space.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19740
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Ief7857365f221b1ef28672a27cc3fb27384c8d0f
Gerrit-Change-Number: 19740
Gerrit-PatchSet: 2
Gerrit-Owner: Maximilian Fridrich <m.fridrich at commend.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Maximilian Fridrich <m.fridrich at commend.com>
Gerrit-Comment-Date: Mon, 23 Jan 2023 08:33:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20230123/9e466402/attachment.html>


More information about the asterisk-code-review mailing list